Upgrade, fix, package, add workflow #23
Conversation
mmarx
commented
May 14, 2025
mmarx
commented
- Add nix flake
- Upgrade Astro, starlight, and dependencies
- Fix broken links
- Add workflow checking for broken links
| (Object.entries(formats) as [keyof typeof formats, Format][]).map(([_key, format]) => { | ||
|
|
||
| // Specify the styling of each parameter | ||
| return ( |
There was a problem hiding this comment.
More of a curiosity: In the next line React would like to have a key on TabItem like <TabItem key={...} to identify the elements of the resulting array. Omitting it would show a warning in the browsers dev tools at least in the development environment (not sure about production). Astro does not want that?
There was a problem hiding this comment.
I'll check, apart from renaming key, I did not touch the line any further.
There was a problem hiding this comment.
I know, that's also why I couldn't mark the exact line :D
I was just curious, this is quite out of scope of this PR and likely needs to be checked in other places too (if it is even an issue at all).
There was a problem hiding this comment.
Not only does it now want that, it also doesn't allow you to set that, see https://starlight.astro.build/components/tabs/#tabitem-props. But then again, we're just generating static HTML, so I guess there's also no need to actually identify the elements.
